[webkit-reviews] review denied: [Bug 45428] [chromium] Add chromium port API for accessing Web Timing information : [Attachment 66976] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 45428: [chromium] Add chromium port API for accessing Web Timing
information
https://bugs.webkit.org/show_bug.cgi?id=45428

Attachment 66976: Patch
https://bugs.webkit.org/attachment.cgi?id=66976&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=66976&action=review

comments are mainly minor

> WebKit/chromium/src/WebFrameImpl.h:94
> +    virtual WebPerformance performance() const;

any reason why this is not
virtual WebPerformance&

> WebKit/chromium/src/WebPerformance.cpp:44
> +

shouldn't this be
WebPerformance::WebPerformance(const WebPerformance& p)
     : m_private(p)

> WebKit/chromium/src/WebPerformance.cpp:55
> +

i think this happens automatically in C++ unless you say explicit in the
constructor

> WebKit/chromium/src/WebPerformance.cpp:154
> +

this should be at the top with the other constructor

> WebKit/chromium/src/WebPerformance.cpp:160
> +

ditto with the other operator=