[webkit-reviews] review requested: [Bug 46120] RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing : [Attachment 68320] Fix + layout test + fixed "expected" file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 21 17:54:47 PDT 2010


Cosmin Truta <ctruta at chromium.org> has asked  for review:
Bug 46120: RenderImage::intrinsicSizeChanged crashes when m_imageResource is
missing
https://bugs.webkit.org/show_bug.cgi?id=46120

Attachment 68320: Fix + layout test + fixed "expected" file
https://bugs.webkit.org/attachment.cgi?id=68320&action=review

------- Additional Comments from Cosmin Truta <ctruta at chromium.org>
James, I'm so grateful for finding this out for me. Thank you!

I don't know how I lost the trailing '\n', probably while copying+pasting, and
their lack didn't seem to cause any issue in the Chromium test runs.
When I resubmitted the job to the trybots, all of them (mac, linux, windows)
were happy as well.

I already resubmitting the fixed patch, could you please review and
commit-queue it?
(Or, should I have submitted only the '\n\n' change this time?)


More information about the webkit-reviews mailing list