[webkit-reviews] review granted: [Bug 46099] check-webkit-style and the coding style guidelines page are inconsistent : [Attachment 68213] proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 21 17:45:24 PDT 2010


Darin Adler <darin at apple.com> has granted Balazs Kelemen <kbalazs at webkit.org>'s
request for review:
Bug 46099: check-webkit-style and the coding style guidelines page are
inconsistent
https://bugs.webkit.org/show_bug.cgi?id=46099

Attachment 68213: proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=68213&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I think it’s fine to make this clearer in this fashion. Ordered as “sort” would
do was intended to be ordered as sort would sort the entire source lines, not
just the filenames, and so that’s why there’s no separate rule about this
today.

If it was me, I would simply add some system header to the existing example
instead of making this a separate rule, but I’m OK with it like this too.

I don’t think this really requires webkit-dev discussion. This rule has not
changed.


More information about the webkit-reviews mailing list