[webkit-reviews] review granted: [Bug 45984] [Qt] QtWebProcess should clean up shared memory map files on close : [Attachment 68109] proposed patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 21 03:36:29 PDT 2010
Csaba Osztrogonac <ossy at webkit.org> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 45984: [Qt] QtWebProcess should clean up shared memory map files on close
https://bugs.webkit.org/show_bug.cgi?id=45984
Attachment 68109: proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=68109&action=review
------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68109&action=review
> WebKit2/Shared/qt/MappedMemoryPool.cpp:29
> +#include "MappedMemory.h"
> +
> +#include "StdLibExtras.h"
#include "config.h" should be the first include,
please add it before landing. Otherwise LGTM, r=me.
More information about the webkit-reviews
mailing list