[webkit-reviews] review requested: [Bug 45383] [Gtk] Incorrect exposure of list items whose children are elements : [Attachment 68206] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 45383: [Gtk] Incorrect exposure of list items whose children are elements
https://bugs.webkit.org/show_bug.cgi?id=45383

Attachment 68206: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=68206&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #5)
> (From update of attachment 67918 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=67918&action=review
> 
> > WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:76
> > +	 // Include all list items, regardless they have or not inline children

> 
> seems like you already have "role" here, so you shouldn't have to call
roleValue() again

Done and also fixed the same mistake in the next line (introduced some commits
ago).

> > WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:2031
> > +		 if (role != TableRole &&
axRenderObject->renderer()->childrenInline())
> 
> you should verify renderer() is not nil before accessing inline children

Done.

> > WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:2036
> > +		     AccessibilityObject* axRenderChild =
axRenderObject->firstChild();
> 
> Can't you just access ->children() of the axRenderObject and then check if it
has an item in it? that would be the first accessible element.

Done.