[webkit-reviews] review granted: [Bug 45897] Web Inspector: highlight DOM node when hover on link element or DOM breakpoint : [Attachment 67805] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 17 04:57:30 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 45897: Web Inspector: highlight DOM node when hover on link element or DOM
breakpoint
https://bugs.webkit.org/show_bug.cgi?id=45897

Attachment 67805: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=67805&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67805&action=prettypatch

> WebCore/inspector/front-end/BreakpointsSidebarPane.js:188
> +   
WebInspector.panels.elements.decorateNodeLabel(WebInspector.domAgent.nodeForId(
this._breakpoint.nodeId), link);

please mind nullable nodes.


More information about the webkit-reviews mailing list