[webkit-reviews] review denied: [Bug 45922] Remove scroll and clip layers for WKCACFLayerRenderer : [Attachment 67874] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 17 04:53:43 PDT 2010
Chris Marrin <cmarrin at apple.com> has denied Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 45922: Remove scroll and clip layers for WKCACFLayerRenderer
https://bugs.webkit.org/show_bug.cgi?id=45922
Attachment 67874: Patch
https://bugs.webkit.org/attachment.cgi?id=67874&action=review
------- Additional Comments from Chris Marrin <cmarrin at apple.com>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67874&action=prettypatch
> WebCore/page/Frame.cpp:883
> + GraphicsLayer* rootLayer = compositor->layerTreeAsTextRootLayer();
The name of this call is very confusing. I know you're trying to say that this
is the root layer you would use when calling layerTreeAsText, but that seems
awfully specific. Why not just combine the calls, naming it something like
'rootLayerTreeAsText()' and have it return a string?
More information about the webkit-reviews
mailing list