[webkit-reviews] review requested: [Bug 45934] Cleanup: Extract common border radii expansion code in RenderBoxModelObject::paintBoxShadow() into function : [Attachment 67860] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 45934: Cleanup: Extract common border radii expansion code in
RenderBoxModelObject::paintBoxShadow() into function
https://bugs.webkit.org/show_bug.cgi?id=45934

Attachment 67860: Patch
https://bugs.webkit.org/attachment.cgi?id=67860&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
I was not sure what to call the function or how best to incorporate the
knowledge that we also clamp the rects to non-negative dimensions. Some name
ideas were uniformlyExpandAndClampToNonNegativeDimensionsBorderRadii,
uniformlyExpandAndClampNegativeToZeroBorderRadii, and
uniformlyExpandBorderRadiiAndClampToNonNegativeDimensions. I felt these were a
bit verbose and didn't read well so I went with uniformlyExpandBorderRadii. I
am open to suggestions.