[webkit-reviews] review granted: [Bug 45932] Crash due to timer triggered GC occuring while other global data is active : [Attachment 67859] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 16 16:38:23 PDT 2010


Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 45932: Crash due to timer triggered GC occuring while other global data is
active
https://bugs.webkit.org/show_bug.cgi?id=45932

Attachment 67859: Patch
https://bugs.webkit.org/attachment.cgi?id=67859&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me

APIEntryShim is probably a better abstraction to use here.

It's pretty subtle when you should use JSLock vs APIEntryShim. We should work
to clear that up in the future.


More information about the webkit-reviews mailing list