[webkit-reviews] review requested: [Bug 45927] CrashTracer: 1, 382 crashes in Safari at com.apple.WebCore: WebCore::VisiblePosition::canonicalPosition + 78 : [Attachment 67850] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 16 15:50:46 PDT 2010


chris fleizach <cfleizach at apple.com> has asked	for review:
Bug 45927: CrashTracer: 1,382 crashes in Safari at com.apple.WebCore:
WebCore::VisiblePosition::canonicalPosition + 78
https://bugs.webkit.org/show_bug.cgi?id=45927

Attachment 67850: patch
https://bugs.webkit.org/attachment.cgi?id=67850&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
The solution in this patch is:


The AXObjectCache instance now keeps a HashSet of Node's being used. When a
node becomes deallocated, it removes itself
from the HashSet. When creating a VisiblePosition from an AXTextMarker, the
cache can then check if the node is valid
before proceeding.


More information about the webkit-reviews mailing list