[webkit-reviews] review granted: [Bug 41155] In FrameLoader, m_URL is not set before calling client dispatchDidCommitLoad for cached pages : [Attachment 67839] Patch with unwanted comments removed

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dinu Jacob <dinu.jacob at Nokia.com>'s
request for review:
Bug 41155: In FrameLoader, m_URL is not set before calling client
dispatchDidCommitLoad for cached pages
https://bugs.webkit.org/show_bug.cgi?id=41155

Attachment 67839: Patch with unwanted comments removed
https://bugs.webkit.org/attachment.cgi?id=67839&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67839&action=prettypatch

> WebCore/ChangeLog:9
> +	   When loading a cached page, dispatchDidCommitLoad is called after
FrameLoader::open so
> +	   that all initialzations are done before calling client
dispatchDidCommitLoad to avoid
> +	   client from accessing incorrect data.
> +	   https://bugs.webkit.org/show_bug.cgi?id=41155
> +

Ideally we'd mention the test here, but I don't think its worth re-spinning the
patch.

> WebCore/loader/FrameLoader.cpp:1857
> +	   // If we have a title let the WebView know about it. 
> +	   String title = m_documentLoader->title();
> +	   if (!title.isNull()) 
> +	       m_client->dispatchDidReceiveTitle(title);	 

On the subject of useless comments.  :)