[webkit-reviews] review denied: [Bug 43683] Implement iframe.srcdoc : [Attachment 67328] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Justin Schuh <jschuh at chromium.org>'s
request for review:
Bug 43683: Implement iframe.srcdoc
https://bugs.webkit.org/show_bug.cgi?id=43683

Attachment 67328: Patch
https://bugs.webkit.org/attachment.cgi?id=67328&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67328&action=prettypatch

You should also do the parts in the parser.

> WebCore/html/HTMLIFrameElement.cpp:76
> -	   return SandboxNone;
> +	   return hasAttribute(srcdocAttr) ? SandboxAll : SandboxNone;

Is this what the WG decided?

> WebCore/html/HTMLIFrameElement.cpp:140
> +#if ENABLE(SANDBOX)

We should get rid of this ifdef, but that's for another patch.

> WebCore/html/HTMLIFrameElement.cpp:190
> +	   const String srcdoc = fastGetAttribute(HTMLNames::srcdocAttr);

We don't use const here.  Also, we're probably using the HTMLNames namespace. 
No need to be explicit here.

> WebCore/html/HTMLIFrameElement.cpp:200
> +    if (!hasAttribute(srcdocAttr))
> +	   return srcdocURL();

This not seems wrong.