[webkit-reviews] review granted: [Bug 45903] Reduce use of HTMLInputElement::inputType so we can remove it later : [Attachment 67814] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <andreas.kling at nokia.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 45903: Reduce use of HTMLInputElement::inputType so we can remove it later
https://bugs.webkit.org/show_bug.cgi?id=45903

Attachment 67814: Patch
https://bugs.webkit.org/attachment.cgi?id=67814&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
> -	   if (!e->hasTagName(inputTag) ||
static_cast<HTMLInputElement*>(e)->inputType() != HTMLInputElement::IMAGE)
> +	   if (!e->hasTagName(inputTag) ||
static_cast<HTMLInputElement*>(e)->isImageButton())

Second condition is reversed (missing "!")

r=me with that fixed.