[webkit-reviews] review granted: [Bug 45890] [v8] Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation : [Attachment 67796] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 16 07:44:44 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 45890: [v8] Web Inspector: [REGRESSION] Scripts disappear from scripts
panel after navigation
https://bugs.webkit.org/show_bug.cgi?id=45890

Attachment 67796: Patch
https://bugs.webkit.org/attachment.cgi?id=67796&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67796&action=prettypatch

> WebKit/chromium/src/WebDevToolsAgentImpl.cpp:267
>	   frontendLoaded();

I'd rather create InspectorController::reconnectFrontend that would internally
call connectFrontend(),  restoreDebugger() and restoreProfiler(). Latter ones
can be private then.


More information about the webkit-reviews mailing list