[webkit-reviews] review denied: [Bug 45680] [WINCE] Add FrameNetworkingContextWinCE::blockedError : [Attachment 67657] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 16 07:46:06 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 45680: [WINCE] Add FrameNetworkingContextWinCE::blockedError
https://bugs.webkit.org/show_bug.cgi?id=45680

Attachment 67657: Patch
https://bugs.webkit.org/attachment.cgi?id=67657&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67657&action=prettypatch

> WebKit/wince/WebCoreSupport/FrameNetworkingContextWinCE.cpp:55
> +WebCore::ResourceError FrameNetworkingContextWinCE::blockedError(const
WebCore::ResourceRequest&) const
> +{
> +    notImplemented();
> +    return WebCore::ResourceError();
> +}

There's no need for any of the "WebCore::"s here, since you have "using
namespace WebCore;" near the top of the file.


More information about the webkit-reviews mailing list