[webkit-reviews] review granted: [Bug 45426] [Chromium] fast/dom/dataset-gc.html is failing : [Attachment 67631] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted Erik Arvidsson
<arv at chromium.org>'s request for review:
Bug 45426: [Chromium] fast/dom/dataset-gc.html is failing
https://bugs.webkit.org/show_bug.cgi?id=45426

Attachment 67631: Patch
https://bugs.webkit.org/attachment.cgi?id=67631&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>

> @@ -44,6 +44,7 @@
>  #include "V8DedicatedWorkerContext.h"
>  #include "V8DOMApplicationCache.h"
>  #include "V8DOMMap.h"
> +#include "V8DOMStringMap.h"
>  #include "V8DOMWindow.h"
>  #include "V8EventListenerList.h"
>  #include "V8EventSource.h"

Remove include

> +v8::Handle<v8::Value> toV8(DOMStringMap* impl)
> +{
> +    if (!impl)
> +	   return v8::Null();
> +    v8::Handle<v8::Object> wrapper = V8DOMStringMap::wrap(impl);
> +    // Add a hidden reference from the element to the DOMStringMap.
> +    Element* element = impl->element();
> +    if (!wrapper.IsEmpty() && element)
> +	   V8DOMWrapper::setHiddenReference(V8Element::wrap(element), wrapper);


I think this needs to be toV8(element) rather than V8Element::wrap(element).
wrap() may not handle subclasses of Element correctly.