[webkit-reviews] review denied: [Bug 45798] Unify FILE_SYSTEM and FILE_WRITER enables : [Attachment 67687] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Eric U. <ericu at chromium.org>'s request
for review:
Bug 45798: Unify FILE_SYSTEM and FILE_WRITER enables
https://bugs.webkit.org/show_bug.cgi?id=45798

Attachment 67687: Patch
https://bugs.webkit.org/attachment.cgi?id=67687&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
Do you also need to change WebKit/chromium/AsyncFileWriterChromium.*?

I also notice that ENABLE_FILE_SYSTEM is not defined in
WebKit/chromium/features.gypi.

View in context:
https://bugs.webkit.org/attachment.cgi?id=67687&action=prettypatch

> configure.ac:-913
> -AM_CONDITIONAL([ENABLE_FILE_WRITER],[test "$enable_file_writer" = "yes"])
I think you also need to remove another occurrence of file_writer usage in this
file.

> WebCore/ChangeLog:5
> +	   Unify FILE_SYSTEM and FILE_WRITER enables
Please mention that you're moving towards FILE_SYSTEM guard.

> WebCore/ChangeLog:8
> +	   No new tests.
This line can be removed. No need to mention it if we do not have specific
thing to say here.