[webkit-reviews] review requested: [Bug 45755] [Qt] TestNetscapePlugIn.dll to compile from .pro in Windows : [Attachment 67556] proposed fix for TestNetscapePlugIn

[bugzilla-daemon at webkit.org]

Janne Koskinen <koshuin at gmail.com> has asked  for review:
Bug 45755: [Qt] TestNetscapePlugIn.dll to compile from .pro in Windows
https://bugs.webkit.org/show_bug.cgi?id=45755

Attachment 67556: proposed fix for TestNetscapePlugIn
https://bugs.webkit.org/attachment.cgi?id=67556&action=review

------- Additional Comments from Janne Koskinen <koshuin at gmail.com>
This patch generates one warning about library statement mismatch.
Fix for that can be done by editing TestNetscapePlugin.def by removing np
prefix out of the target library. I didn't change this as I do not have VC6 to
verify if it would break that build. Looking at the code it won't, but maybe
there is someone still relying on prefixed npapi plugins like stated in Mozilla
documentations i.e. filename 8.3 and starts with np - prefix.