[webkit-reviews] review granted: [Bug 40060] Add a version of JSObjectSetPrototype that yields an exception when the prototype can't be set : [Attachment 59358] Fix v1.2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 13 13:28:20 PDT 2010


Geoffrey Garen <ggaren at apple.com> has granted Jędrzej Nowacki
<jedrzej.nowacki at nokia.com>'s request for review:
Bug 40060: Add a version of JSObjectSetPrototype that yields an exception when
the prototype can't be set
https://bugs.webkit.org/show_bug.cgi?id=40060

Attachment 59358: Fix v1.2
https://bugs.webkit.org/attachment.cgi?id=59358&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I don't think we ever want to make JSObjectSetPrototypeWithException public
API.

However, I don't see any downside to adding it as private API -- it doesn't
introduce any new dependencies on the VM.

So, let's compromise by adding this as private API, which Qt library
implementors can use, with the understanding that we're not going to make it
into public API.


More information about the webkit-reviews mailing list