[webkit-reviews] review denied: [Bug 45699] ResourceResponseBase::setMimeType wants mimetype and not content type : [Attachment 67460] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Fridrich Strba
<fridrich.strba at bluewin.ch>'s request for review:
Bug 45699: ResourceResponseBase::setMimeType wants mimetype and not content
type
https://bugs.webkit.org/show_bug.cgi?id=45699

Attachment 67460: Patch
https://bugs.webkit.org/attachment.cgi?id=67460&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67460&action=prettypatch

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:869
> +   
response.setMimeType(g_content_type_get_mime_type(g_file_info_get_content_type(
info)));
It isn't well documented, but this is a memory leak, because
g_content_type_get_mime_type returns a newly-allocated string.