[webkit-reviews] review granted: [Bug 45688] JavaScript dialog should not deactivate media element : [Attachment 67439] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 13 13:17:00 PDT 2010
Geoffrey Garen <ggaren at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 45688: JavaScript dialog should not deactivate media element
https://bugs.webkit.org/show_bug.cgi?id=45688
Attachment 67439: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=67439&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
51 enum ReasonForSuspension {
52 JavaScriptPaused,
53 WillShowDialog,
54 DocumentWillBecomeInactive
55 };
"JavaScriptPaused" is a bit vague. How about "JavaScriptDebuggerPaused"
instead?
r=me
More information about the webkit-reviews
mailing list