[webkit-reviews] review requested: [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text : [Attachment 67463] Single patch for fixing this bug

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 25898: [Gtk] object:text-changed events should be emitted for entries and
password text
https://bugs.webkit.org/show_bug.cgi?id=25898

Attachment 67463: Single patch for fixing this bug
https://bugs.webkit.org/attachment.cgi?id=67463&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #74)
> [...] 
> Thanks Enrica, that's just what I needed. As soon as I finish addressing
other issues in other patches I'll try this out.

I'm now attaching a new patch addressing all the issues you (Enrica) pointed
out so I hope this new patch to be better and, hopefully, closer to help fixing
this bug :-)

Wrt the calculateGlobalOffset() function you (Enrica) were definitely right: I
was messing too much with a loop iterating over nodes while
TextIterator::rangeLength() would basically do everything I needed in a way
better and cleaner fashion. Hence I removed that function in this new patch and
just added the three-line code in the only place it was needed.

So, now asking for review once again. Hopefully this will be the last or one of
the last times I bother you all with this stuff :-) Anyway, don't hesitate to
ask whatever you want, of course.

PS: If you review+ it, please set the cq+ flag as well. Thanks!