[webkit-reviews] review denied: [Bug 45539] [Qt] selected text gets deleted when qgraphicswebview losts focus : [Attachment 67183] proposal fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 10 09:01:52 PDT 2010
Andreas Kling <andreas.kling at nokia.com> has denied yi shen
<yi.4.shen at nokia.com>'s request for review:
Bug 45539: [Qt] selected text gets deleted when qgraphicswebview losts focus
https://bugs.webkit.org/show_bug.cgi?id=45539
Attachment 67183: proposal fix
https://bugs.webkit.org/attachment.cgi?id=67183&action=review
------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
> + if (!ev->preeditString().isEmpty())
Should be "if (!preedit.isEmpty())"
Change looks reasonable, but it needs an autotest (see WebKit/qt/tests/)
More information about the webkit-reviews
mailing list