[webkit-reviews] review denied: [Bug 45522] Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom. : [Attachment 67153] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied  review:
Bug 45522: Remove unnecessary constraint in WebCore of choosing either text
zoom or full page zoom.
https://bugs.webkit.org/show_bug.cgi?id=45522

Attachment 67153: Patch
https://bugs.webkit.org/attachment.cgi?id=67153&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67153&action=prettypatch

> WebKit/chromium/src/FrameLoaderClientImpl.cpp:1401
> +    bool zoomTextOnly = m_webFrame->viewImpl();
viewImpl is of type WebViewImpl*, but you are storing it in a 'bool'.  i think
this is going to force zoomTextOnly to always be true.

i think you meant to write m_webFrame->viewImpl()->zoomTextOnly().

> WebKit/chromium/src/WebViewImpl.cpp:1494
> +	   m_page->setNeedsRecalcStyleInAllFrames();
why isn't this a byproduct of calling set{Text,Page}ZoomFactor?  isn't
unfortunate for WebKit layers to need to understand when to call
setNeedsRecalcStyleInAllFrames?