[webkit-reviews] review granted: [Bug 45214] Rename SecurityOrigin::canLoad to canDisplay : [Attachment 66563] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 3 16:41:23 PDT 2010
Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 45214: Rename SecurityOrigin::canLoad to canDisplay
https://bugs.webkit.org/show_bug.cgi?id=45214
Attachment 66563: Patch
https://bugs.webkit.org/attachment.cgi?id=66563&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + // Returns true if |document| can dispaly content from the given URL
(e.g.,
dispaly
> + // in an iframe or as an image). For example, web sites generally
cannot
> + // display content from the user's files system. If |document| is 0,
> + // |referrer| is used to make this determination.
Are we going to have to go out into the alley and have a throw down over the
two spaces vs. one space after period issue? ;-)
In the programming world I am part of, the word "display" usually means "paint
into a window", so I think the word display here is not perfect. Is there some
terminology from the HTML5 specification or some other technical document that
we can borrow here to find a phrase better than "display the contents"?
More information about the webkit-reviews
mailing list