[webkit-reviews] review granted: [Bug 45161] Add unit tests for interval tree : [Attachment 66465] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 3 16:48:17 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 45161: Add unit tests for interval tree
https://bugs.webkit.org/show_bug.cgi?id=45161
Attachment 66465: Patch
https://bugs.webkit.org/attachment.cgi?id=66465&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66465&action=prettypatch
> WebKit/chromium/tests/PODIntervalTreeTest.cpp:109
> +namespace {
nit: add new line after "namespace {" to match the new line above the closing
bracket
> WebKit/chromium/tests/PODIntervalTreeTest.cpp:150
> +namespace {
nit: add new line below this line
> WebKit/chromium/tests/PODIntervalTreeTest.cpp:199
> + int len = nextRandom(maximumValue);
nit: len -> length
> WebKit/chromium/tests/PODIntervalTreeTest.cpp:210
> + int idx = nextRandom(addedElements.size());
nit: idx -> index
R=me w/ those nits fixed
More information about the webkit-reviews
mailing list