[webkit-reviews] review denied: [Bug 45443] [GTK] Support for viewport meta tag : [Attachment 72287] Proposed Patch9

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Joone Hur <joone at kldp.org>'s
request for review:
Bug 45443: [GTK] Support for viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=45443

Attachment 72287: Proposed Patch9
https://bugs.webkit.org/attachment.cgi?id=72287&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72287&action=review

> WebKit/gtk/webkit/webkitprivate.h:326
> +    void
> +    webkit_viewport_attributes_set(WebKitViewportAttributes*
viewportAttributes, const WebCore::ViewportAttributes& attrs, gboolean
userScalable);

This may be uneeded. See below.

> WebKitTools/DumpRenderTree/LayoutTestController.h:287
> +    void configurationForViewport(int availableWidth, int availableHeight);

This method actually dumps the viewport so it should be called
dumpConfigurationForViewport.

> WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:836
> +    DumpRenderTreeSupportGtk::updateViewportAttributes(webView,
availableWidth, availableHeight);

I'm a little worried because the Qt implementation doesn't actually set the
viewport attributes on the view. Seemingly it just calculates the appropriate
viewport given the size. Shouldn't we try to replicate that as closely as
possible?

Perhaps this should just call a method like this:

WebKitViewportAttributes* attributes =
DumpRenderTreeSupportGtk::computeViewportAttributesForSize(availbleWidth,
availableHeight);