[webkit-reviews] review denied: [Bug 48608] Add text-combine property support to CSS parser : [Attachment 72306] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 29 13:29:54 PDT 2010
Dave Hyatt <hyatt at apple.com> has denied Takumi Takano
<takano1 at asia.apple.com>'s request for review:
Bug 48608: Add text-combine property support to CSS parser
https://bugs.webkit.org/show_bug.cgi?id=48608
Attachment 72306: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=72306&action=review
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I would prefer it if TextCombine was put in StyleRareNonInheritedData instead.
In general we're trying to keep the CSS3 stuff out of the original set of
inherited/noninherited flags, since they will be rarely used. I let
writing-mode slide originally, since I figured it would end up unprefixed
eventually and be compatible with WinIE, but text-combine is going to be pretty
obscure, so let's put it in the rare struct.
More information about the webkit-reviews
mailing list