[webkit-reviews] review granted: [Bug 48555] ASSERT when SVGAnimatedProperty instance is assigned to multiple elements. : [Attachment 72333] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 29 12:26:26 PDT 2010


Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 48555: ASSERT when SVGAnimatedProperty instance is assigned to multiple
elements.
https://bugs.webkit.org/show_bug.cgi?id=48555

Attachment 72333: Patch
https://bugs.webkit.org/attachment.cgi?id=72333&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72333&action=review

r=me

> WebCore/svg/properties/SVGAnimatedProperty.h:46
> +    virtual bool isAnimatedListTearOff() const { return false; }

Didn't we discussed about adding a boolean instead of the virtual
removeItemFromList on the first patch that implemented it? ;-)


More information about the webkit-reviews mailing list