[webkit-reviews] review granted: [Bug 48654] ASSERTION FAILURE in WebProcessProxy::frameDestroyed when a Page is closed before it can send the DidCreateMainFrame message to the UIProcess : [Attachment 72366] Remove the invalid assertion

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 48654: ASSERTION FAILURE in WebProcessProxy::frameDestroyed when a Page is
closed before it can send the DidCreateMainFrame message to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=48654

Attachment 72366: Remove the invalid assertion
https://bugs.webkit.org/attachment.cgi?id=72366&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72366&action=review

> WebKit2/UIProcess/WebProcessProxy.cpp:492
> +	   return;

You can remove the call to m_frameMap.contains here, m_frameMap.remove will
work just fine even if the frame doesn't exist in the map and it will avoid an
extra hash lookup.