[webkit-reviews] review denied: [Bug 5793] HTML OBJECT without width/height attributes doesn't honor the size of the image : [Attachment 72053] Proposed patch with accepting reviewer's comment.

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Julie Jeongeun Kim
<jiyuluna at gmail.com>'s request for review:
Bug 5793: HTML OBJECT without width/height attributes doesn't  honor the size
of the image
https://bugs.webkit.org/show_bug.cgi?id=5793

Attachment 72053: Proposed patch with accepting reviewer's comment.
https://bugs.webkit.org/attachment.cgi?id=72053&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72053&action=review

Making progress!  r- to fix the ChangeLog patch, to use view->size(), and to
include a layout test.

This page (under the "Regression tests" section) talks about how to make a
layout test:  <http://webkit.org/coding/contributing.html>

It's probably just as easy to look at existing layout tests to figure out how
to write one.

Note that I haven't reviewed this patch for correctness of behavior yet--just
getting through some of the basic issues first.  Comment #21 concerns me,
though, in that these changes don't fix the test cases attached to the bug.

> WebCore/ChangeLog:-106
> -2010-10-27  Adam Roben  <aroben at apple.com>

The ChangeLog patch is still deleting old ChangeLog entries.  There should only
be the new ChangeLog added to the top of the file.

> WebCore/html/ImageDocument.cpp:300
> +	   IntSize windowSize = IntSize(view->width(), view->height());

Please change to:

    IntSize windowSize = view->size();