[webkit-reviews] review denied: [Bug 48365] Remove output parameters from JITStackFrame : [Attachment 71987] The patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 48365: Remove output parameters from JITStackFrame
https://bugs.webkit.org/show_bug.cgi?id=48365

Attachment 71987: The patch
https://bugs.webkit.org/attachment.cgi?id=71987&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71987&action=review

> JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:-2445
> -			developmentRegion = English;

update xcode!

> JavaScriptCore/interpreter/Interpreter.cpp:419
> +    if (eval) {
> +	   result = callFrame->globalData().interpreter->execute(eval.get(),
callFrame,
callFrame->r(codeBlock->thisRegister()).jsValue().toThisObject(callFrame),
callFrame->registers() - registerFile->start() + registerOffset, scopeChain);
> +	   if (callFrame->hadException()) {
> +	       exceptionValue = callFrame->exception();
> +	       callFrame->clearException();
> +	   }
> +    }

this should be
if (!eval)
    return jsUndefined();
...

> JavaScriptCore/jit/JITOpcodes.cpp:1066
> +    peek(regT3, OBJECT_OFFSETOF(struct JITStackFrame, globalData) / sizeof
(void*));

excess space after sizeof

> JavaScriptCore/jit/JITStubs.cpp:1066
> +struct ExceptionHandler { void* catchRoutine; CallFrame* callFrame; };

this should be one line per field.