[webkit-reviews] review denied: [Bug 48220] constraint validation: stepMismatch (rounding error) : [Attachment 71719] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 25 01:51:16 PDT 2010
Kent Tamura <tkent at chromium.org> has denied Dai Mikurube
<dmikurube at google.com>'s request for review:
Bug 48220: constraint validation: stepMismatch (rounding error)
https://bugs.webkit.org/show_bug.cgi?id=48220
Attachment 71719: Patch
https://bugs.webkit.org/attachment.cgi?id=71719&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71719&action=review
You need to add a test case to
LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js
> WebCore/html/NumberInputType.cpp:120
> + // Accepts errors in the equvalent precision to IEEE 754
single-precision numbers and additional 7-bits.
This comment doesn't match to the code?
More information about the webkit-reviews
mailing list