[webkit-reviews] review denied: [Bug 48221] Number values should be in the range of IEEE 754 single-precision floating point number : [Attachment 71718] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Dai Mikurube
<dmikurube at google.com>'s request for review:
Bug 48221: Number values should be in the range of IEEE 754 single-precision
floating point number
https://bugs.webkit.org/show_bug.cgi?id=48221

Attachment 71718: Patch
https://bugs.webkit.org/attachment.cgi?id=71718&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71718&action=review

> LayoutTests/ChangeLog:9
> +

Our standard ChangeLog entry format is:

Reviewed By ...

<Single-line change description, typically it's a title of the corresponding
bug>
<bug URL>

<More description>

* <file>: <comments for the file>

We use identical single-line description in LayoutTests/ChangeLog and
WebCore/ChangeLog.
The short description in your ChangeLog should be moved after the bug URL.

> WebCore/html/parser/HTMLParserIdioms.cpp:86
> +    // Numbers are considered finite IEEE 754 single-precision floating
point values.

I think we need to update serializeForNumberType() in HTMLParserIdioms.cpp too
so that it doesn't show digits out of the single-precision.