[webkit-reviews] review granted: [Bug 48174] Filter example Chiseled from SVG Wow! is slow : [Attachment 71691] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 24 10:58:49 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 48174: Filter example Chiseled from SVG Wow! is slow
https://bugs.webkit.org/show_bug.cgi?id=48174

Attachment 71691: Patch
https://bugs.webkit.org/attachment.cgi?id=71691&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71691&action=review

r=me, but please use assignment operators everywhere.

> JavaScriptCore/ChangeLog:19
> +2010-10-24  Dirk Schulze  <krit at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Filter example Chiseled from SVG Wow! is slow
> +	   https://bugs.webkit.org/show_bug.cgi?id=48174
> +
> +	   * wtf/ByteArray.h:

ChangeLog contains double entries.

> WebCore/platform/graphics/filters/FEBlend.cpp:106
> +    ByteArray* srcPixelArrayA(srcImageDataA->data()->data());

Please use the assignment operator: ByteArray* srcPixelArrayA = srcImage...


More information about the webkit-reviews mailing list