[webkit-reviews] review granted: [Bug 48207] Web Inspector: slowly make old resources panel optional. : [Attachment 71684] [PATCH] Proposed change.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 48207: Web Inspector: slowly make old resources panel optional.
https://bugs.webkit.org/show_bug.cgi?id=48207

Attachment 71684: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=71684&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71684&action=review

> WebCore/ChangeLog:34
> +	   Web Inspector: add support for errors, warnings and search to the
storage panel.

Double ChangeLog.

> WebCore/inspector/front-end/inspector.js:-233
> -	   if (hiddenPanels.indexOf("scripts") === -1)

Why remove the hidden panels stuff? I think this si used by some OS X WebKit
clients.

> WebCore/inspector/front-end/inspector.js:1690
> +    if (WebInspector.resourceManager) {

Add a newline before this one.