[webkit-reviews] review requested: [Bug 48190] [WINCE] Port COMPtr.h to WinCE : [Attachment 71648] Patch

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 48190: [WINCE] Port COMPtr.h to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48190

Attachment 71648: Patch
https://bugs.webkit.org/attachment.cgi?id=71648&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #2)
> (From update of attachment 71646 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=71646&action=review
> 
> r- to fix header sort order since this is a cq? patch.
Why don't you set it to r+ and add a comment about whats needed to be ok?


> > WebCore/platform/win/COMPtr.h:35
> > +#include <wtf/Assertions.h>
> > +#include <wtf/HashTraits.h>
> >  #include <unknwn.h>
> 
> Nit: <unkwn.h> is alphabetically before <wtf/...h>.  Please realphabetize.
Don't we usually add WebKit headers befor external headers?


> > WebCore/platform/win/COMPtr.h:-36
> > -#include <WTF/Assertions.h>
> > -#include <WTF/HashTraits.h>
> 
> Nice catch re: WTF!
It's windows, so not a real problem until we cross compile form e.g. linux. ;-)