[webkit-reviews] review granted: [Bug 48163] Calling FileReader.abort during reading could cause crash : [Attachment 71611] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Oct 23 11:09:42 PDT 2010
David Levin <levin at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 48163: Calling FileReader.abort during reading could cause crash
https://bugs.webkit.org/show_bug.cgi?id=48163
Attachment 71611: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=71611&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71611&action=review
> WebCore/fileapi/FileReader.cpp:266
> + if (m_state != Aborting)
Seems like "fail fast" would be better.
if (m_state == Aborting)
return;
More information about the webkit-reviews
mailing list