[webkit-reviews] review granted: [Bug 16395] Inspector needs to use cached resources : [Attachment 71405] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 21 03:07:30 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 16395: Inspector needs to use cached resources
https://bugs.webkit.org/show_bug.cgi?id=16395

Attachment 71405: patch
https://bugs.webkit.org/attachment.cgi?id=71405&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71405&action=review

> WebCore/inspector/front-end/Resource.js:621
> +	   if (typeof this._contentEncoded !== "undefined")

May be just use a separate flag _contetRequested?

> WebCore/inspector/front-end/Resource.js:635
> +	   if (this.frameID) {

style: please remove the brackets


More information about the webkit-reviews mailing list