[webkit-reviews] review granted: [Bug 47905] Redesign SVGAnimatedProperty concept to share "POD type wrappers" between all bindings (-> add ObjC SVG bindings) : [Attachment 71402] Patch v8
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 21 02:55:40 PDT 2010
Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 47905: Redesign SVGAnimatedProperty concept to share "POD type wrappers"
between all bindings (-> add ObjC SVG bindings)
https://bugs.webkit.org/show_bug.cgi?id=47905
Attachment 71402: Patch v8
https://bugs.webkit.org/attachment.cgi?id=71402&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71402&action=review
> WebCore/bindings/scripts/CodeGeneratorV8.pm:1065
> +
remove the spaces
Had a looong review session on skype. Really great patch. And a very detailed
test suite.
r=me
More information about the webkit-reviews
mailing list