[webkit-reviews] review denied: [Bug 37205] Implement CSSOM View matchMedia interface : [Attachment 71215] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Luiz Agostini <luiz at webkit.org>'s
request for review:
Bug 37205: Implement CSSOM View matchMedia interface
https://bugs.webkit.org/show_bug.cgi?id=37205

Attachment 71215: patch
https://bugs.webkit.org/attachment.cgi?id=71215&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71215&action=review

> WebCore/css/MediaQueryListListener.cpp:52
> +    return other && other->m_value.isEqual(state, m_value);

The use of isEqual here is wrong. It should just be:

    return other && m_value == other->m_value;

And you need test cases covering this. Calling out to arbitrary JavaScript here
as isEqual would can create major problems including security vulnerabilities.