[webkit-reviews] review denied: [Bug 47990] [GTK] Replace encodings multi-dimensional array with calls to registrar method : [Attachment 71300] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 47990: [GTK] Replace encodings multi-dimensional array with calls to
registrar method
https://bugs.webkit.org/show_bug.cgi?id=47990

Attachment 71300: Patch
https://bugs.webkit.org/attachment.cgi?id=71300&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71300&action=review

I love this patch. Just a couple small nits.

> WebCore/platform/text/gtk/TextCodecGtk.cpp:92
> +bool TextCodecGtk::registerEncodingAliasIfAvailable(EncodingNameRegistrar
registrar, const char* canonicalName, const char* aliasName)

It looks like you never check the return value of this method. Can it just
return void?

> WebCore/platform/text/gtk/TextCodecGtk.h:60
> +	   static bool registerEncodingNameIfAvailable(EncodingNameRegistrar
registrar, const char* canonicalName);
> +	   static bool registerEncodingAliasIfAvailable(EncodingNameRegistrar
registrar, const char* canonicalName, const char* aliasName);
> +	   static void registerCodecIfAvailable(TextCodecRegistrar registrar,
const char* codecName);
>  

Could these these can just be static functions in TextCodecGtk.cpp?