[webkit-reviews] review granted: [Bug 47835] The description parameter of IDBFactory::open() should be mandatory. : [Attachment 71058] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 18 10:59:08 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has granted Andrei Popescu
<andreip at google.com>'s request for review:
Bug 47835: The description parameter of IDBFactory::open() should be mandatory.
https://bugs.webkit.org/show_bug.cgi?id=47835

Attachment 71058: Patch
https://bugs.webkit.org/attachment.cgi?id=71058&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71058&action=review

r=me

> LayoutTests/storage/indexeddb/basics.html:57
> +

nit: extra newline not required

> WebCore/ChangeLog:8
> +	   Makes the description parameter mandatory, as per the
IndexedDatabase specification.

Add a mention of existing tests being modified to cover it.


More information about the webkit-reviews mailing list