[webkit-reviews] review denied: [Bug 47034] gl-teximage.html fails on chromium webkit mac bot : [Attachment 71050] revised patch: fixed the skia port compile error

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 47034: gl-teximage.html fails on chromium webkit mac bot
https://bugs.webkit.org/show_bug.cgi?id=47034

Attachment 71050: revised patch: fixed the skia port compile error
https://bugs.webkit.org/attachment.cgi?id=71050&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
There are two issues with this code as written. One is that it does not
properly handle the case where the machine's native byte order is big endian
rather than little endian. The second and more significant is that it
unnecessarily complicates the code for a relatively rare case of 16-bit PNGs
with byte order opposite of the machine's native byte order. The endianness
switch does not need to be passed all the way down to the unpacking routine.
Instead, another few unpacking routines for 16-bit source values can be added
like unpackR16ToRGBA8Swapped, where that would be used if the source byte order
was big endian and the native machine's byte order is little endian. A run-time
test can be added to packPixels to determine whether the machine is big or
little endian. "uint16_t tempValue = 1; if
(reinterpret_cast<uint8_t*>(&tempValue)[0] == 1) { /* little endian */ } else {
/* big endian */ }"