[webkit-reviews] review denied: [Bug 47514] CSS transforms should affect scrolling : [Attachment 70786] Patch to add topmostPosition()

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Beth Dakin <bdakin at apple.com>'s request
for review:
Bug 47514: CSS transforms should affect scrolling
https://bugs.webkit.org/show_bug.cgi?id=47514

Attachment 70786: Patch to add topmostPosition()
https://bugs.webkit.org/attachment.cgi?id=70786&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70786&action=review

> WebCore/rendering/RenderBlock.cpp:3387
> +		   }

This is still not right.  The if statement should be identical to the one in
lowestPosition.  You should be checking x + width and x + rightmostPosition,
and you're looking for objects to the left of the root (just like what
lowestPosition does).  What you have in the body of the if statement is
correct.

> WebCore/rendering/RenderBlock.cpp:3413
> +    }

Just yank these three lines.  The following check supersedes them.