[webkit-reviews] review denied: [Bug 47689] REGRESSION (r69548): Autocorrections are applied even after typing further characters in the word : [Attachment 70785] Proposed patch (v2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 14 15:42:27 PDT 2010


Mark Rowe (bdash) <mrowe at apple.com> has denied jpu at apple.com's request for
review:
Bug 47689: REGRESSION (r69548): Autocorrections are applied even after typing
further characters in the word
https://bugs.webkit.org/show_bug.cgi?id=47689

Attachment 70785: Proposed patch (v2)
https://bugs.webkit.org/attachment.cgi?id=70785&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70785&action=review

> WebCore/editing/Editor.cpp:2901
> +	   m_rangeToBeReplacedByCorrection.release();

release() on a RefPtr returns a PassRefPtr and clears out the RefPtr.  This
code isn’t interested in the return value of the release() method so it would
be more obvious to call clear() instead.


More information about the webkit-reviews mailing list