[webkit-reviews] review requested: [Bug 40273] Canvas: "currentColor" should inherit the canvas element's color : [Attachment 70728] proposed warning fix for r69755

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 14 05:22:19 PDT 2010


Csaba Osztrogonac <ossy at webkit.org> has asked  for review:
Bug 40273: Canvas: "currentColor" should inherit the canvas element's color
https://bugs.webkit.org/show_bug.cgi?id=40273

Attachment 70728: proposed warning fix for r69755 
https://bugs.webkit.org/attachment.cgi?id=70728&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
http://trac.webkit.org/changeset/69755 caused warnings
because of missing default cases:

../../../WebCore/html/canvas/CanvasStyle.cpp:157: warning: control reaches end
of non-void function
../../../WebCore/html/canvas/CanvasStyle.cpp:143: warning: control reaches end
of non-void function
../../../WebCore/html/canvas/CanvasStyle.cpp:86: warning: control reaches end
of non-void function


More information about the webkit-reviews mailing list