[webkit-reviews] review granted: [Bug 47257] DeviceOrientation crash when page is in page cache and is navigated while listener is registered : [Attachment 70725] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 47257: DeviceOrientation crash when page is in page cache and is navigated
while listener is registered
https://bugs.webkit.org/show_bug.cgi?id=47257

Attachment 70725: Patch
https://bugs.webkit.org/attachment.cgi?id=70725&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70725&action=review

r=me

>
LayoutTests/fast/dom/DeviceOrientation/script-tests/event-after-navigation.js:1

> +description('Tests for a crash where an event is fired after the page has
been navigated away when the original page is in the page cache.<br><br>Note
that the crash is only seen with V8.');

Is there any reason this crash can only possibly happen in V8?	If not, this
comment probably should be removed, even if we currently only see it in V8.  If
so, it should probably mention why it's V8 specific.  This way it'll be clear
whether the comment is stale.