[webkit-reviews] review granted: [Bug 47632] Only draw focus ring in RenderInline and RenderImage if the theme is not able to draw a focus ring : [Attachment 70686] Patch with pixel-tests

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 47632: Only draw focus ring in RenderInline and RenderImage if the theme is
not able to draw a focus ring
https://bugs.webkit.org/show_bug.cgi?id=47632

Attachment 70686: Patch with pixel-tests
https://bugs.webkit.org/attachment.cgi?id=70686&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70686&action=review

> WebCore/rendering/RenderInline.cpp:995
> +    paintFocusRing(graphicsContext, tx, ty, styleToUse);

The vast majority of elements don’t have a focus ring to draw, but now we will
make a function call and check the theme before we quickly discover there is
nothing to draw.

> WebCore/rendering/RenderObject.cpp:1197
> +    paintFocusRing(graphicsContext, tx, ty, styleToUse);

Same comment here. Can we preserve the inline fast check even if the bulk of
the painting is left in a non-inline function.