[webkit-reviews] review granted: [Bug 46105] [BREWMP] Add TextBoundaries and TextBreakIterator : [Attachment 68113] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 46105: [BREWMP] Add TextBoundaries and TextBreakIterator
https://bugs.webkit.org/show_bug.cgi?id=46105

Attachment 68113: Patch
https://bugs.webkit.org/attachment.cgi?id=68113&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68113&action=review

> WebCore/platform/text/brew/TextBoundariesBrew.cpp:37
> +int findNextWordFromIndex(const UChar * buffer, int len, int position, bool
forward)

The position of "*" is noncommittal.  We usually use "const UChar* buffer".

> WebCore/platform/text/brew/TextBoundariesBrew.cpp:43
> +void findWordBoundary(const UChar * buffer, int len, int position, int*
start, int* end)

ditto.